Subscription feature tests #3352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aataraxiaa
reviewed
Sep 12, 2024
There was a problem hiding this comment.
All looks good at a high-level @miasma13 , no red flags. I’ll review more in-depth tomorrow. Left one minor comment.
DuckDuckGoTests/Subscription/SubscriptionPagesUseSubscriptionFeatureTests.swift
Outdated
Show resolved
Hide resolved
aataraxiaa
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Looks good @miasma13 👍🏼. Needs a main rebase/merge and then should be good to go.
miasma13
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Sep 17, 2024
**Required**: Task/Issue URL: https://app.asana.com/0/1200019156869587/1207743313459997/f iOS PR: duckduckgo/iOS#3352 macOS PR: duckduckgo/macos-browser#3259 What kind of version bump will this require?: Minor **Description**: Shared library BSK Subscription feature tests. **Steps to test this PR**: 1. Run `SubscriptionTests` test bundle --- ###### Internal references: [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1200019156869587/1207743313459997/f
Description:
Client side iOS Subscription feature tests.
Steps to test this PR:
Definition of Done (Internal Only):
Internal references:
Software Engineering Expectations
Technical Design Template